Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked examples folder and fixed Readme #139

Merged
merged 6 commits into from
Jan 28, 2018
Merged

reworked examples folder and fixed Readme #139

merged 6 commits into from
Jan 28, 2018

Conversation

StrikerRUS
Copy link
Member

This PR moves RGF examples into separate subfolder RGF and renames fast_rgf to FastRGF.

Also Troubleshooting section is reworked (the main change - #13 is no more actual since we are checking input X and understandable exception is raised in such cases).

@fukatani fukatani merged commit ea2a697 into RGF-team:master Jan 28, 2018
@fukatani
Copy link
Member

fukatani commented Jan 28, 2018

LGTM!
And we can change description to
The wrapper of machine learning algorithm Regularized Greedy Forest and FastRGF.
in readme

@StrikerRUS
Copy link
Member Author

I believe that the algorithm is RGF, but one of the implementation is named FastRGF.
I think (will create a PR) that the note about supporting two backends shoud be placed in Features section of Readme.

@StrikerRUS StrikerRUS deleted the examples branch January 28, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants