Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the tests file in R-package #232

Merged
merged 1 commit into from
Aug 23, 2018
Merged

updated the tests file in R-package #232

merged 1 commit into from
Aug 23, 2018

Conversation

mlampros
Copy link
Collaborator

This pull request is a continuation of #230. In this PR I modified the initial test file in the following ways:

  • I renamed the test file from test_package.R to test-RGF_package.R
  • I added context('rgf R-package tests') at the top of the test-RGF_package.R as suggested in the testthat documentation

StrikerRUS
StrikerRUS approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

fukatani
fukatani approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlampros mlampros merged commit bf423fb into master Aug 23, 2018
@StrikerRUS StrikerRUS deleted the R-package-tests branch August 23, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@fukatani fukatani fukatani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlampros @fukatani @StrikerRUS