Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with roxygen2 > 7.0 #343

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Conversation

StrikerRUS
Copy link
Member

Unfortunately, installation of texlive-latex-extra didn't help (refer to microsoft/LightGBM#4084).
But looks like I've found minimal bundle of TeX packages required to be compatible with roxygen2 > 7.0. The main one was hyperref, absence of which caused CRAN checks to fail with ! Undefined control sequence. l.152 \hypertarget error.

Copy link
Collaborator

@mlampros mlampros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, that's nice because it takes time to write the documentation for each method of the R6 class separately. I tried it for a personal project. We can invest some time in the future for RGF when it will be required for CRAN submission.

@mlampros mlampros merged commit f5c2f43 into R-package-update-cran Mar 21, 2021
@StrikerRUS StrikerRUS deleted the dev branch March 21, 2021 21:18
StrikerRUS added a commit that referenced this pull request Mar 22, 2021
* update to CRAN version 1.0.7

* added the _R_CHECK_EXAMPLE_TIMING_THRESHOLD_ environment variable

* added the _R_CHECK_SYSTEM_CLOCK_ environment variable

* modified the r_tests.sh

* modified the r_tests.sh

* modified the r_tests.sh

* fix some errors in R-package after upgrade to 1.0.7 (#342)

* fixes

* test

* test

* fixes

* fixes

* fixes

* fixes

* fix compatibility with roxygen2 > 7.0 (#343)

* Update .ci/r_tests_windows.ps1

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update .ci/r_tests_windows.ps1

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/tests/testthat/helper-skip.R

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants