Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowjo_to_gatingset does not handle gates on uncompensated channels #89

Closed
jacobpwagner opened this issue May 4, 2020 · 2 comments
Closed

Comments

@jacobpwagner
Copy link
Member

jacobpwagner commented May 4, 2020

FlowJo allows users to add gates on both the compensated and uncompensated values of any channel (as well as the transformed and untransformed values). The current design of cytolib and flowWorkspace is to have a single column for each channel to which compensation and transformation are applied (although that column can be inverted or decompensated on-the-fly if need be). The fact that we do not hold on to the uncompensated channel values causes parsing failures for any workspace that has gates on the uncompensated values of a channel that has been compensated.

I am putting this issue in CytoML, but depending on how we tackle it, the work may end up being more in cytolib and flowWorkspace. This may be another reason to consider switching to storing values on raw scale and then applying compensation or transformation when necessary.

I've attached a very simple workspace to demonstrate the issue and use for testing purposes.
uncompensated_issue.tar.gz

@jacobpwagner
Copy link
Member Author

jacobpwagner commented Jun 15, 2020

This is fixed by cdb3b5e, but required some additions to cytolib (RGLab/cytolib@b7dd39e). I'm leaving this open for a bit to allow for updates in the near term.

@jacobpwagner
Copy link
Member Author

Closing this as everything appears to be functioning appropriately after the changes and no issues have appeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant