Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lwip: add auto-init support for transciever ENC28J60 #13092

Merged
merged 1 commit into from
Feb 5, 2020
Merged

pkg/lwip: add auto-init support for transciever ENC28J60 #13092

merged 1 commit into from
Feb 5, 2020

Conversation

Ciusss89
Copy link
Contributor

Contribution description

pkg/lwip: add auto-init support for transciever ENC28J60

Testing procedure

I pinged the node from my laptop, code here

Issues/PRs references

@aabadie aabadie added Area: network Area: Networking Area: pkg Area: External package ports labels Jan 16, 2020
@benpicco
Copy link
Contributor

Thank you for your patch!
The code is the same as for esp32 and stm32, but please use 4 spaces for indentation to make Travis happy.

Then this should be good to go.

@benpicco benpicco added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jan 30, 2020
@Ciusss89
Copy link
Contributor Author

Ciusss89 commented Jan 31, 2020 •
edited
Loading

The indentation should be ok.

Thank you for your patch!

you're welcome ;)

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 31, 2020
benpicco
benpicco approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, patch is analogous to the other netif drivers.

@benpicco benpicco merged commit f144a12 into RIOT-OS:master Feb 5, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
@Ciusss89 Ciusss89 deleted the lwip_enc28j60 branch February 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
4 participants
@Ciusss89 @benpicco @aabadie @leandrolanzieri