native: easify NATIVEINCLUDES usage #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clever =) |
|
The commit message is a bit misleading/ambiguous ... I would have gone with something containing: |
Currrently native overrides the object file targets, because it needs the different include paths to interact with libc and the OS. This PR simplifies their makefiles to only override the variable INCLUDES, instead of overriding the targets.
|
I changed the message. |
|
ACK |
LudwigKnuepfer
added a commit
that referenced
this pull request
Jul 8, 2014
native: easify NATIVEINCLUDES usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.