Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/gnrc_dhcpv6_client: Fix term and increase timeout [backport 2020.04] #13963

Merged
merged 2 commits into from
Apr 27, 2020
Merged

tests/gnrc_dhcpv6_client: Fix term and increase timeout [backport 2020.04] #13963

merged 2 commits into from
Apr 27, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Backport of #13961

Contribution description

This PR changes the way ethos is called in the gnrc_dhcpv6_client test (removes sh) and increases the timeout a bit. The test application is supposed to print the interface information after 5 seconds, but sometimes the test script timeouts before the application can print it.

Testing procedure

  • Run test/gnrc_dhcpv6_client application test.

Issues/PRs references

None

@leandrolanzieri leandrolanzieri added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 27, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 27, 2020
Merged
miri64
miri64 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Same change as upstream

@leandrolanzieri leandrolanzieri merged commit b2a9ea6 into RIOT-OS:2020.04-branch Apr 27, 2020
@leandrolanzieri leandrolanzieri deleted the backport/2020.04/pr/tests/gnrc_dhcpv6_client/fix_test branch April 27, 2020 15:14
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 27, 2020
Closed
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @miri64