Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esptool.py: use Python3 #14392

Merged
merged 1 commit into from
Jun 30, 2020
Merged

esptool.py: use Python3 #14392

merged 1 commit into from
Jun 30, 2020

Conversation

benpicco
Copy link
Contributor

Contribution description

All our tools use python3 and esptool.py also works fine with it.
To avoid having to install dependencies twice and switch away from EOL Python2, convert esptool.py to use Python3.

Testing procedure

Flashing esp8266 & esp32 should still work.

Issues/PRs references

alternative to #14033

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jun 29, 2020
@benpicco benpicco requested a review from gschorcht June 29, 2020 21:37
@gschorcht gschorcht mentioned this pull request Jun 30, 2020
Closed
gschorcht
gschorcht approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works with this change.

@gschorcht
Copy link
Contributor

Weird, CI run tests didn't flash and executed the tests on the ESP32 board but only on nrf52dk` where a number of tests failed.

@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 30, 2020
@gschorcht
Copy link
Contributor

Weird, CI run tests didn't flash and executed the tests on the ESP32 board but only on nrf52dk` where a number of tests failed.

I restarted the build in Murdock. If it failes again due to unrelated errors, we shouldn't build with CI run tests.

@benpicco
Copy link
Contributor Author

AFAIR esp32 was blacklisted from CI, looks like a hardware failure.

@gschorcht
Copy link
Contributor

AFAIR esp32 was blacklisted from CI

Why that? At least in last nighlty esp32-wroom-32 was used and didn't show any error.

@benpicco
Copy link
Contributor Author

Hm looks like it was just a single test #14238

@benpicco benpicco removed the CI: run tests If set, CI server will run tests on hardware for the labeled PR label Jun 30, 2020
@benpicco
Copy link
Contributor Author

run_test/examples/micropython/nrf52dk:gnu keeps failing, but that doesn't use esptool

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 30, 2020
@gschorcht gschorcht merged commit 7554abd into RIOT-OS:master Jun 30, 2020
@benpicco benpicco deleted the esptool-python3_only branch June 30, 2020 11:57
@miri64 miri64 added this to the Release 2020.07 milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @gschorcht @miri64