Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riotctrl_shell.netif: fix for multiple interfaces with netstats #14510

Merged
merged 2 commits into from
Jul 15, 2020
Merged

riotctrl_shell.netif: fix for multiple interfaces with netstats #14510

merged 2 commits into from
Jul 15, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 14, 2020 •
edited
Loading

Contribution description

This provides a fix to riotctrl_shell.netif for when there is more than one interface and network statistics are provided. I also added a regression test for that.

Testing procedure

cd dist/pythontools/riotctrl_shell; tox, or just let tools-test do its thing :-)

Issues/PRs references

Required for the test integration of release spec 10-icmpv6-error (see RIOT-OS/Release-Specs#167).

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Jul 14, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 14, 2020
@miri64 miri64 requested a review from jia200x July 14, 2020 12:38
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 14, 2020
This was referenced Jul 14, 2020
Merged
Closed
@miri64
Copy link
Member Author

miri64 commented Jul 14, 2020

I pushed 92957e5 first so you can see, that the test is failing without the fix.

@jia200x
Copy link
Member

jia200x commented Jul 15, 2020

ok, makes sense. I trust the output of tool-test

jia200x
jia200x approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x merged commit 90911f4 into RIOT-OS:master Jul 15, 2020
@miri64 miri64 deleted the riotctrl.netif/bug/multi-iface-w-stats branch July 15, 2020 13:24
@miri64 miri64 mentioned this pull request Jul 15, 2020
Merged
@miri64
Copy link
Member Author

miri64 commented Jul 15, 2020

Backport provided in #14522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @jia200x