examples/micropython: fix checked PID #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With #14224 the idle thread became optional, so the main thread can have either 1 or 2 as PID, depending if the idle thread is included or not. As this might also change in the future, it is probably the best to just expect any number.
miri64
added
Type: bug
miri64
added
CI: ready for build
fjmolinas
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
ACK can reproduce:
pr
...
...
def inc_a(): global a; a+=1
...
>>> t = xtimer.xtimer(inc_a)
t = xtimer.xtimer(inc_a)
>>> utime.time()
utime.time()
2273
>>> t.set(500000)
t.set(500000)
>>> while a==0: pass
while a==0: pass
...
>>> utime.time()
utime.time()
2897
>>> [TEST PASSED]
master
BOARD=iotlab-m3 make -C examples/micropython test
make: Entering directory '/home/francisco/workspace/RIOT2/examples/micropython'
miniterm --eol LF "/dev/riot/tty-iotlab-m3" "500000"
--- Miniterm on /dev/riot/tty-iotlab-m3 500000,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
�main(): This is RIOT! (Version: 2020.10-devel-1-g5599b-pr-14518)
-- Executing boot.py
boot.py: MicroPython says hello!
-- boot.py exited. Starting REPL..
MicroPython v1.4.2-6568-gbb8e51f6d on 2020-07-15; riot-iotlab-m3 with stm32
Type "help()" for more information.
>>> print("echo this! " * 4)
print("echo this! " * 4)
echo this! echo this! echo this! echo this!
>>> import riot
print(riot.thread_getpid())
import riot
>>> print(riot.thread_getpid())
1
>>> Timeout in expect script at "child.expect_exact('2')" (examples/micropython/tests/01-run.py:25)
cgundogan
added
CI: ready for build
miri64
added
the
Process: needs backport
81 tasks
|
Murdock failures as most of the times when using |
miri64
added
CI: skip compile test
|
It seems that the PR branch was pushed on the RIOT main fork. I deleted it. |
|
Yeah sorry 'bout that. I pushed this from the repo the release manager created since I accidentally was working there 😅 |
|
Backport provided in #14530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
With #14224 the idle thread became optional, so the main thread can have either 1 or 2 as PID, depending if the idle thread is included or not. As this might also change in the future, it is probably the best to just expect any number.
Testing procedure
Should now succeed again on e.g. Cortex-M platforms.
Issues/PRs references
Follow-up on #14224