-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/gnrc_dhcpv6_client: fix expected output #14524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Area: network
Area: Networking
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Process: needs backport
Integration Process: The PR is required to be backported to a release or feature branch
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
labels
Jul 15, 2020
81 tasks
benpicco
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch works on native
, but the test is buggy:
- on
native
it is required to rundist/tools/tapsetup/tapsetup
before the test works. This is not documented. - on a board (e.g.
samr21-xpro
withethos
) the test does not work at all askea-dhcp6.conf
hard-codestapbr0
.
Where should this be documented if not in the README (where it is documented) ;-) |
Also documented in the test's README... |
Thanks for testing and reviewing :-) |
Backport provided in #14528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: network
Area: Networking
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Process: needs backport
Integration Process: The PR is required to be backported to a release or feature branch
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The output of the shell command
nib prefix show
was changed in #12776 by adding a space between the number of seconds and the unit. Due to this the testtests/gnrc_dhcpv6_client
now fails as it expects the output to be without spaces.As the new
riotctrl_shell
"accidentally" accounted for that "error", I decided to rather fix the test than reverting the addition of the whitespace. There is no other test in master that checks this output.Testing procedure
The test requires
kea
to be installed. It is available in most Linux distributions as a package, but many don't create the status directory of the server:Then run on a board of your choice (that supports
ethos
):make -C tests/gnrc_dhcpv6_client flash sudo make -C tests/gnrc_dhcpv6_client test
Issues/PRs references
Fixes a "regression" introduced in #12776