Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: enable SECONDEXPANSION globally for modules and applications #16198

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Makefile: enable SECONDEXPANSION globally for modules and applications #16198

merged 1 commit into from
Mar 30, 2021

Conversation

fjmolinas
Copy link
Contributor

Contribution description

I realized that actually SECONDEXPANSION was not enabled for applications but only for modules since it was in Makefile.base, so this PR also enables that.

Testing procedure

Test build times?

Issues/PRs references

Split out from #16197.

@fjmolinas fjmolinas added the Area: build system Area: Build system label Mar 16, 2021
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Mar 18, 2021
kaspar030
kaspar030 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

It was documented behavior before, so this change could actually be considered a bug fix.

@fjmolinas fjmolinas merged commit 7806afe into RIOT-OS:master Mar 30, 2021
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
@fjmolinas fjmolinas deleted the pr_enable_secondexpansion branch July 30, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @kaspar030