Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/netif_conn: fix _conn_get_itvl_ms() #16890

Merged
merged 1 commit into from Sep 24, 2021
Merged

nimble/netif_conn: fix _conn_get_itvl_ms() #16890

merged 1 commit into from Sep 24, 2021

Conversation

haukepetersen
Copy link
Contributor

Contribution description

Straight forward bug fix: the validity check for nimble_netif_conn_get_itvl_ms() should test for a handle value < 0, as 0 is actually a valid input value...

Testing procedure

Compile test and code review should do the trick here, as this line is (not yet) used anywhere in RIOT...

Issues/PRs references

none

@haukepetersen haukepetersen added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Sep 24, 2021
@github-actions github-actions bot added the Area: pkg Area: External package ports label Sep 24, 2021
@haukepetersen
Copy link
Contributor Author

all green -> go.

@haukepetersen haukepetersen merged commit e53d6c0 into RIOT-OS:master Sep 24, 2021
@haukepetersen haukepetersen deleted the fix_nimbleconn_getitvl branch September 24, 2021 17:08
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haukepetersen @benpicco