pkg/paho-mqtt: fix memory corruption #17503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes instances where a pointer to an enum (possibly sized one byte) is casted to a pointer to int (which is at least two and in most cases four bytes in size). As result, out-of-bounds memory accesses are bound to happen. This was detected by GCC 11.2.0 with -Wstringop-overflow.
github-actions
bot
added
Area: network
maribu
added
CI: ready for build
|
Reported issue upstream: eclipse/paho.mqtt.embedded-c#233 Maybe upstream acts so promptly that we could just bump the version instead. |
benpicco
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This fixes instances where a pointer to an
enum(possibly sized one byte) is casted to a pointer toint(which is at least two and in most cases four bytes in size). As result, out-of-bounds memory accesses are bound to happen.This was detected by GCC 11.2.0 with
-Wstringop-overflow.Testing procedure
Green Murdock & pkg should still work as before
Issues/PRs references
Found in #17004