sys/cpp_new_delete: always enable the module when C++ is used

[benpicco]

Contribution description

Newer toolchains appear to expect the presence of __dso_handle, so always enable the module.
The linker will collect unused sections anyway.

Testing procedure

sys/cpp_ctors builds again on Ubuntu 23.10.

On master it would produce

/usr/lib/gcc/arm-none-eabi/12.2.1/../../../arm-none-eabi/bin/ld: /usr/lib/gcc/arm-none-eabi/12.2.1/../../../arm-none-eabi/lib/thumb/v7e-m/nofp/libstdc++_nano.a(eh_globals.o): in function `_GLOBAL__sub_I___cxa_get_globals_fast':
./build_nano/thumb/v7e-m/nofp/libstdc++/libsupc++/../../../../../../src/libstdc++-v3/libsupc++/eh_globals.cc:85: undefined reference to `__dso_handle'
/usr/lib/gcc/arm-none-eabi/12.2.1/../../../arm-none-eabi/bin/ld: /home/benpicco/dev/RIOT/tests/sys/cpp_ctors/bin/nucleo-wl55jc/tests_cpp_ctors.elf: hidden symbol `__dso_handle' isn't defined

Issues/PRs references

[riot-ci]

Murdock results

✔️ PASSED

453a8be sys/cpp_new_delete: always enable the module when C++ is used

Success	Failures	Total	Runtime
10013	0	10015	09m:37s

Artifacts

• Documentation preview

[maribu]

@MrKevinWeiss This might be something to backport. I think it is safe to assume that this doesn't break things, and hence, doesn't invalidate release testing.

[MrKevinWeiss]

OK...

[MrKevinWeiss]

Actually, since this is a fix for a specific distro I think it can land just in the 2024.01-branch and we will include it in future point releases if needed (it takes quite a while to get it in otherwise)...

[benpicco]

It should become relevant when riotdocker switches to Ubuntu 24.04

[maribu]

For the CI the docker image is tagged. But a user running BUILD_IN_DOCKER=1 may expect the most recent docker image to just work.

Anyway, if it is in the 2024.01-branch, that is already good. I personally recommend going for the branch rather than the tag anyway, as the branch gets relevant fixes backported well after the release. The downside is that no regression tests are performed, unless a point release is made.

[MrKevinWeiss]

It should become relevant when riotdocker switches to Ubuntu 24.04

won't that be after the next release?