-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/wakaama: implement IPSO sensor objects in LwM2M #20652
pkg/wakaama: implement IPSO sensor objects in LwM2M #20652
Conversation
6eaf99e
to
c1713e5
Compare
Cool! There are some merge conflicts and static white space issues. |
c1713e5
to
527cab6
Compare
I fixed the conflicts and ran uncrustify on all files. Yes, this is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some static tests are not happy with your whitespace.
Hope I got all now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash pls!
071ae29
to
3d96491
Compare
Thanks for the review! |
Contribution description
This PR adds implementations for various IPSO sensor objects to LwM2M. This is (hopefully) a first step towards automatically exposing SAUL devices to LwM2M. The implemented objects are:
Given that all objects share common properties and functionalities, there's a base IPSO sensor object that is used by the specific object implementations. The base implementation deals with resource access and instance allocation.
Testing procedure
All objects include documentation on their usage, you can include that code on
examples/lwm2m
to test.Issues/PRs references
None