pkg: Add script to check third party package version #20662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested changes
May 15, 2024
There was a problem hiding this comment.
Thanks, that seems to be a nice addition!
From a very quick glance at the changes, already some comments:
- could you adapt the script to follow our python coding convention? In particular, provide and use a
mainfunction (also move initialization code there), add a copyright notice and shorten lines longer than 120 chars. - could you move the script under
dist/tools/pkg_version_check(or similar) and provide a (short) README explaining its function?
mguetschow
reviewed
May 15, 2024
|
Tried it locally, the python file is missing the executable rights ( 👀 I think it would be nice to provide more concise output, only listing failures and outdated packages. |
github-actions
bot
added
Area: doc
|
I've moved the script to |
mguetschow
requested changes
May 24, 2024
|
Thanks for the suggestions, I've updated the script and the README |
mguetschow
added
the
CI: ready for build
mguetschow
reviewed
May 24, 2024
mguetschow
approved these changes
May 24, 2024
namberino
force-pushed
the
pkg-makefile_version_check
branch
from
90846ae
to
3927a4f
Compare
|
Sorry for closing the request, I accidentally rebased. |
namberino
force-pushed
the
pkg-makefile_version_check
branch
from
0be9c2d
to
2c1f413
Compare
|
Should be good now. |
maribu
reviewed
May 24, 2024
namberino
force-pushed
the
pkg-makefile_version_check
branch
from
402658b
to
0c49709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This provides a script that will read the Makefile of third party packages in the
pkg/directory and compare thePKG_VERSIONhash with the latest upstream release hash or commit hash and check if the package is outdated or not.The script requires a GitHub API token to run.
Testing procedure
Running the script and inputing a GitHub API token should print out a list of outdated packages.
Issues/PRs references
Fixes #13911