Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use restrict instead of __restrict #2401

Closed

Conversation

cgundogan
Copy link
Member

In some places the keyword __restrict is used, in other places restrict.
IMHO only one form should be used throughout riot. In this PR I favoured restrict by removing the leading underscores of __restrict.

EDIT: I did some more research and realized that restrictis not available in g++. Is then __restrict or __restrict__ the better route to go?
https://gcc.gnu.org/onlinedocs/gcc/Restricted-Pointers.html

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Feb 7, 2015
@cgundogan
Copy link
Member Author

@Kijewski I would like to hear your opinion on this topic

@LudwigKnuepfer
Copy link
Member

Here is the input by @Kijewski on that topic: #2042

@cgundogan
Copy link
Member Author

@LudwigOrtmann Okay, but then again, there are still a lot of restricts used. I will close this PR and open a new one-

@LudwigKnuepfer
Copy link
Member

I don't really care if you close this and replace with a new one or just change the title and content...

@cgundogan cgundogan closed this Feb 7, 2015
@cgundogan cgundogan deleted the restrict_without_leading_underscores branch March 17, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants