Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board-support: cc2650stk #4675

Merged
merged 6 commits into from
Apr 19, 2016
Merged

Conversation

yogo1212
Copy link
Contributor

do i need a license header? if so, what's your recommendation for a 'do whatever the fuck you want'-style license?

@yogo1212 yogo1212 force-pushed the cc2650stk_pr branch 7 times, most recently from 18c25bd to baf93e0 Compare January 25, 2016 15:30
@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jan 25, 2016
@haukepetersen haukepetersen added this to the Release 2016.03 milestone Jan 25, 2016
@haukepetersen haukepetersen self-assigned this Jan 25, 2016
@emmanuelsearch
Copy link
Member

The default license we use is LGPLv2.1. I think you should use a header similar to the one in dist/tools/ethos/ethos.c for example.
(adapt your name and email of course ;)

@OlegHahm
Copy link
Member

No license means that you grant no rights to use your code to anyone as far as I know.

@yogo1212
Copy link
Contributor Author

@OlegHahm @haukepetersen ping :-)

@OlegHahm
Copy link
Member

@yogo1212, did you change anything else than the copyright notice? Usually, a PR should not be squashed until the reviewer says so. (See rule 9 of the development procedures).

@yogo1212
Copy link
Contributor Author

@OlegHahm damn. sry. i didn't know about those :-(
no, i didn't change anything grave.
i've added more defines to prcm and fixed a duplicate value - as far as i can remember

@@ -0,0 +1,9 @@
FEATURES_PROVIDED += periph_cpuid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the template as in other Makefile.features files here, e.g. from boards/stm32f4discovery/Makefile.features

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this?

@yogo1212
Copy link
Contributor Author

yogo1212 commented Apr 18, 2016

@haukepetersen rebase on current master, commits unchanged
..
and i have a question regarding these:

        Building application: bindist (2/14) .......
                failed .. retrying .. retrying: cc2650stk
                success: arduino-due, cc2538dk, fox, iotlab-m3, mbed_lpc1768, nucleo-f103

BUILDTEST_MCU_GROUP=cortex_m3_1 dist/tools/travis-scripts/build_and_test.sh has cc2650stk fail almost everywhere..

cd examples/bindist ; BOARD=cc2650stk make clean all
works though.

do you have an explanation? i'm trying to figure it out atm

@yogo1212
Copy link
Contributor Author

yogo1212 commented Apr 18, 2016

found it using make buildtest
this is the error:
/home/leon/git/RIOT/boards/cc2650stk/Makefile.include:13: *** Please point the environment var UNIFLASH_PATH to your uniflash path. Stop.

@yogo1212
Copy link
Contributor Author

@haukepetersen ping again :-)
should now build successfully

just tell me when to squash :-p

@yogo1212
Copy link
Contributor Author

lalalalalalalilalalilala

@yogo1212
Copy link
Contributor Author

yogo1212 commented Apr 18, 2016

murdock helps saving the planet :-)
stops building old states when new stuff is pushed - nice

@haukepetersen
Copy link
Contributor

Could you just squash the 2 cpuid fixed into the cpu: add CC26x0-family commit and the boardfix default UNIFLASH_PATH to prevent buildtest from failing into the boards: add cc2650stk, then I will be happy to press the merge button :-)

@yogo1212
Copy link
Contributor Author

@haukepetersen happy merging! :-p

@haukepetersen
Copy link
Contributor

CI is happy -> and go

@haukepetersen haukepetersen merged commit c0f76f2 into RIOT-OS:master Apr 19, 2016
@haukepetersen
Copy link
Contributor

but no need to backport to the current RC1

@yogo1212 yogo1212 deleted the cc2650stk_pr branch April 19, 2016 11:54
@yogo1212
Copy link
Contributor Author

yogo1212 commented Apr 19, 2016

@emmanuelsearch :-)
@haukepetersen shiver i might be allergic to the word 'backport'..

@OlegHahm
Copy link
Member

So, main open issues for this board are currently a missing radio driver and problems with the timer, right?

@emmanuelsearch
Copy link
Member

@yogo1212 great. On to the next steps!
Is there an issue open for the timer problem?
Is there a PR WIP for the radio? @yogo1212 you are currently working on the 802.15.4 mode, correct?

@haukepetersen
Copy link
Contributor

Is there an issue open for the timer problem?

now there is.

@yogo1212
Copy link
Contributor Author

@emmanuelsearch I could open a PR with the WIP - if you like.
If you just want to look, here it is: https://github.com/yogo1212/RIOT/tree/cc26x0_rfc

Right now, nothing has been done specific to either BLE or 802.15.4. Communication with the RF module is unstable. Do you prefer one?
There are arguments to start with either: I can use my notebook to test BLE or use existing support for 802.15.4 in RIOT (have no hardware, though)

@emmanuelsearch
Copy link
Member

@yogo1212 would love BLE, but for not the stack we have in RIOT has support for 802.15.4 so start with that mode. We can lend some SAMR21 to interop with it, no problem. BLE will be second phase. @haukepetersen you are of the same opinion?

@haukepetersen
Copy link
Contributor

yes

@emmanuelsearch
Copy link
Member

@yogo1212 could you open a wiki page for this board with instructions how to flash it etc.?
(e.g. https://github.com/RIOT-OS/RIOT/wiki/Board%3A-Mulle)

@yogo1212
Copy link
Contributor Author

@emmanuelsearch my firefox crashed and the github-magic for saving the content failed as well..
had to start again and now it's too late -.-
https://github.com/RIOT-OS/RIOT/wiki/Board%3A-CC2650STK

gn8 ;-)

@emmanuelsearch
Copy link
Member

thanks @yogo1212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants