Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/mulle: Add SAUL GPIO parameters for onboard LEDs #4860

Merged
merged 1 commit into from
Mar 21, 2016
Merged

boards/mulle: Add SAUL GPIO parameters for onboard LEDs #4860

merged 1 commit into from
Mar 21, 2016

Conversation

jnohlgard
Copy link
Member

Adds configuration for SAUL to use the onboard LEDs, similar to what is configured on iotlab-m3.

Untested on actual hardware, I will test the configuration tomorrow or monday when I have a mulle board nearby.

@jnohlgard jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Feb 20, 2016
@jnohlgard jnohlgard mentioned this pull request Feb 20, 2016
Merged
@haukepetersen
Copy link
Contributor

Could we wait for #4862 to merge this?

Otherwise: code looks good - untested ACK

@cgundogan
Copy link
Member

I won't have access to a mulle board until friday. Will test then if nobody tests before.

@jnohlgard
Copy link
Member Author

@haukepetersen yes, let's wait for #4862

@jnohlgard jnohlgard added the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 22, 2016
@jnohlgard jnohlgard mentioned this pull request Feb 22, 2016
Closed
@DipSwitch
Copy link
Member

#4862 is merged

@DipSwitch DipSwitch added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 19, 2016
@DipSwitch
Copy link
Member

Tested it on another board but SAUL GPIO seems to work :)

But the .pin and .pull definitions need to be updated.

@DipSwitch DipSwitch removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 19, 2016
@jnohlgard
Copy link
Member Author

rebased after #4862 was merged.
Tested in examples/default with saul write x 0|1

@jnohlgard jnohlgard added this to the Release 2016.04 milestone Mar 19, 2016
@jnohlgard jnohlgard added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 19, 2016
@haukepetersen
Copy link
Contributor

ACK and go.

haukepetersen added a commit that referenced this pull request Mar 21, 2016
@haukepetersen
Merge pull request #4860 from gebart/pr/mulle-saul-gpio
05730e4 
boards/mulle: Add SAUL GPIO parameters for onboard LEDs
@haukepetersen haukepetersen merged commit 05730e4 into RIOT-OS:master Mar 21, 2016
@jnohlgard jnohlgard deleted the pr/mulle-saul-gpio branch March 29, 2016 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cgundogan cgundogan

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
4 participants
@jnohlgard @haukepetersen @cgundogan @DipSwitch