-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/cc2538: fix build errors when UART1 or the 32 kHz crystal is enabled #5124
Conversation
Oops, sorry! |
let's test this tomorrow ;-) |
Did you? |
I'm on it ;) |
On which hardware did you tested? I'm trying with cc2538dk and remote without success... |
@kYc0o I tested this on a custom PCB (similar to cc2538dk, but with two dedicated UARTs). But the patch is intended primarily to fix a compile-time issue. Please try the following. Test 1Modify
Then
This build fails.
This build succeeds. Test 2Add
This build fails.
This build succeeds. |
@kYc0o: are you still on it? |
Ok yeah, sorry for the delay I forgot it... I'll test this now |
Tests succeed. There's a small error on the board's definition but I'll PR it afterwards. So ACK and since Murdock is ok we can merge it ASAP. @haukepetersen everything's ok for you too? |
Murdock and Travis are OK -> GO! |
Needs backport. |
4780b5c introduced a couple of build errors that aren't apparent unless
UART_1_EN=1
orSYS_CTRL_OSC32K_USE_XTAL=1
. This patch fixes both.