Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys: net: crosslayer: fixed inet csum for 16bit platforms #5191

Merged
merged 1 commit into from
Apr 10, 2016

Conversation

malosek
Copy link
Contributor

@malosek malosek commented Mar 29, 2016

Hello,

proposing inet_csum fix for 16bit platforms.
wo explicit type conversion *buff << 8 is treated as signed (checked with gcc-msp430 and TI CGT)

wbr
malo

Signed-off-by: malo <malo@25cmsquare.io>
@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: MSP Platform: This PR/issue effects MSP-based platforms Area: network Area: Networking labels Mar 29, 2016
@OlegHahm OlegHahm added this to the Release 2016.07 milestone Mar 29, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Apr 10, 2016

While trying to communicate using a radio attached to an Arduino MEGA 2560 I faced the same problem.
ICMPv6 messages need to be checked using this function so for 8bit processors the explicit cast was also needed.

Code looks good and it works so ACK.

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 10, 2016
@kYc0o kYc0o modified the milestones: Release 2016.04, Release 2016.07 Apr 10, 2016
@kYc0o
Copy link
Contributor

kYc0o commented Apr 10, 2016

Murdock is green -> GO!

@kYc0o kYc0o merged commit 82696da into RIOT-OS:master Apr 10, 2016
@malosek malosek deleted the inet_csum_16bit_fix branch April 10, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants