Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: ethos: misc fixes #5211

Merged
merged 2 commits into from
Mar 30, 2016
Merged

drivers: ethos: misc fixes #5211

merged 2 commits into from
Mar 30, 2016

Conversation

kaspar030
Copy link
Contributor

Two small ethos fixes:

  • add previously missing "random" dependency
  • allow "recv" to be called with a buffer larger than needed

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 30, 2016
@kaspar030 kaspar030 added this to the Release 2016.04 milestone Mar 30, 2016
OlegHahm
OlegHahm reviewed Mar 30, 2016
View reviewed changes
drivers/ethos/ethos.c
@@ -297,11 +297,12 @@ static int _recv(netdev2_t *netdev, char* buf, int len, void* info)
ethos_t * dev = (ethos_t *) netdev;

if (buf) {
if (len != dev->last_framesize) {
if (len <= dev->last_framesize) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be < instead of <=? Anyway the debug line needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both correct. amended a fix.

@OlegHahm
Copy link
Member

ACK

@OlegHahm OlegHahm merged commit 4f17d2b into RIOT-OS:master Mar 30, 2016
@kaspar030 kaspar030 deleted the ethos_fixes branch March 31, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cgundogan cgundogan

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @OlegHahm @cgundogan