drivers: misc fixes for encx24j600 #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Type: bug
kaspar030
added
the
CI: ready for build
| @@ -96,12 +96,13 @@ void encx24j600_setup(encx24j600_t *dev, const encx24j600_params_t *params) | |||
| static void encx24j600_isr(void *arg) | |||
| { | |||
| encx24j600_t *dev = (encx24j600_t *) arg; | |||
| netdev2_t *netdev = (netdev2_t *) arg; | |||
There was a problem hiding this comment.
wouldn't it be simpler, if you cast arg only to netdev2_t * and use that instead of dev->netdev. below?
There was a problem hiding this comment.
ok, it's only cosmetic anyway.
|
changes look good, ACK once my comment has been addressed. |
|
Murdock is happy -> go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver didn't compile for a while, so this PR
The test application is basically a copy of tests/driver_enc28j60.