at86rf2xx_netdev: fix broken pending_tx handling #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: bug
cgundogan
added
the
Impact: major
| if (dev->pending_tx > 0) { | ||
| dev->pending_tx--; | ||
| } | ||
|
|
||
| if (dev->pending_tx == 0) { |
There was a problem hiding this comment.
How about --dev->pending_tx == 0 instead?
There was a problem hiding this comment.
is it guaranteed that dev->pending_tx != 0 when entering this code path? I could also put an assert there, whadayasay?
There was a problem hiding this comment.
assert may make sense indeed. pending_tx should always be > 0 for this code path...
|
addressed comments |
cgundogan
added
the
CI: needs squashing
|
ACK - please squash. |
cgundogan
force-pushed
the
pr/at86rf2xx_netdev/fix
branch
from
c0c9805
to
9b01c6d
Compare
cgundogan
added
CI: ready for build
|
squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
at86rf2xx_netdevis broken.The driver will never go into
idlestate, becausedev->pending_txis decreased after the decision is made whether the device should go to idle or not.Result: no outgoing packets anymore. Can be tested on the iotlab testbed. ping doesn't work anymore.
The second commit is just a bonus and transforms a
printfinto aDEBUG.