Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: icmpv6_echo: guard call to *_nc_still_reachable #5320

Merged
merged 1 commit into from
Apr 17, 2016
Merged

shell: icmpv6_echo: guard call to *_nc_still_reachable #5320

merged 1 commit into from
Apr 17, 2016

Conversation

cgundogan
Copy link
Member

gnrc_ipv6_nc_still_reachable is not available when gnrc_ipv6_nc is not compiled into the binary.

@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation GNRC labels Apr 14, 2016
@cgundogan cgundogan added this to the Release 2016.07 milestone Apr 15, 2016
@miri64
Copy link
Member

miri64 commented Apr 17, 2016

Why would you compile IPv6 without address resolution, but ICMPv6?

@cgundogan
Copy link
Member Author

cgundogan commented Apr 17, 2016 •
edited
Loading

ICMPv6 does not stand for address resolution. So, why shouldn't I compile IPv6 without address resolution, but with ICMPv6?

@miri64
Copy link
Member

miri64 commented Apr 17, 2016

Err forgot about the stuff you were trying with implicit address resolution... ACK and go when murdock is happy.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 17, 2016
@miri64 miri64 merged commit f90b607 into RIOT-OS:master Apr 17, 2016
@cgundogan cgundogan deleted the pr/shell/icmpv6_without_nc branch April 17, 2016 14:37
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundogan @miri64