-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: add nanocoap #5972
pkg: add nanocoap #5972
Conversation
(launching CI to check for build errors) |
* pkg provided by commit from kaspar030 add_pkg_nanocoap branch. See pending PR RIOT-OS#5972.
USEMODULE += gnrc_icmpv6_echo | ||
|
||
# | ||
USEMODULE += gnrc_conn_udp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs port to sock ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. :)
USEMODULE += gnrc_netdev_default | ||
USEMODULE += auto_init_gnrc_netif | ||
# Specify the mandatory networking modules for IPv6 and UDP | ||
USEMODULE += gnrc_ipv6_router_default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making this only a host #6007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a follow-up.
d576d2c
to
6933831
Compare
6933831
to
7c79a62
Compare
aa64d68
to
abb6ac0
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Copper on native (and the provided example). ACK!
and go. |
Here's the first PR regarding nanocoap.
While nanocoap contains client functionality, that depends on sock, so I've decided to add that at a later stage.
The PR includes an example application that has almost exactly the same functionality as
microcoap_example
(it's also based on conn for now).Here's a code/memory comparison:
Thats 1416b code / 576b RAM for nanocoap and 2055b code / 2108b RAM for microcoap.
The comparison is favoring nanocoap, as microcoap currently has a little more functionality (it adds content types to /.well-known/core), and its buffers could probably be made smaller. Then again, it is not easy to determine how big they should be for microcoap, which was one of the main reasons why I started the rewrite.
Also, nanocoap only needs 57 lines of CoAP specific SLOC for this simple example, while microcoap needs ~130.