Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndp: Add constant for retrans. timer exp. backoff maximum #7179

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jun 13, 2017

Adds a constant for the retransmission timer in exponential backoff for UNREACHABLE state (see RFC 7048).

@miri64 miri64 added the Area: network Area: Networking label Jun 13, 2017
@miri64 miri64 requested a review from cgundogan June 13, 2017 09:46
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 13, 2017
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 13, 2017
@miri64 miri64 assigned cgundogan and smlng and unassigned cgundogan Jun 13, 2017
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me!

@@ -153,6 +153,12 @@ extern "C" {
#define NDP_MAX_NA_NUMOF (3U) /**< MAX_NEIGHBOR_ADVERTISEMENT */
#define NDP_REACH_MS (30000U) /**< REACHABLE_TIME (in ms) */
#define NDP_RETRANS_TIMER_MS (1000U) /**< RETRANS_TIMER (in ms) */
/**
* @brief MAX_RETRANS_TIMER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in ms)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and amended immediately.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 13, 2017
@cgundogan cgundogan merged commit 58067bd into RIOT-OS:master Jun 13, 2017
@miri64 miri64 deleted the ndp/enh/backoff-max branch June 13, 2017 13:09
@aabadie aabadie modified the milestone: Release 2017.07 Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants