Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] sys/cbor: fix compilation with newlib #7819

Merged
merged 3 commits into from
Oct 24, 2017
Merged

[backport] sys/cbor: fix compilation with newlib #7819

merged 3 commits into from
Oct 24, 2017

Conversation

kYc0o
Copy link
Contributor

@kYc0o kYc0o commented Oct 24, 2017

Backport of #7783

@kYc0o kYc0o added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 24, 2017
@kYc0o kYc0o added this to the Release 2017.10 milestone Oct 24, 2017
@kYc0o kYc0o requested a review from miri64 October 24, 2017 14:31
@haukepetersen haukepetersen changed the title sys/cbor: fix compilation with newlib [backport] sys/cbor: fix compilation with newlib Oct 24, 2017
@haukepetersen
Copy link
Contributor

changed the title for clarity

miri64
miri64 previously approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go

@miri64
Copy link
Member

miri64 commented Oct 24, 2017

(needs rebase though)

@miri64
Copy link
Member

miri64 commented Oct 24, 2017

Please rebase (not merge)

@kYc0o
Copy link
Contributor Author

kYc0o commented Oct 24, 2017

I'm trying to 😂

@miri64
Copy link
Member

miri64 commented Oct 24, 2017

It's like with master. Just use (the most current) 2017.10-branch as your base branch instead of master ;-P

miri64
miri64 approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK

@kYc0o
Copy link
Contributor Author

kYc0o commented Oct 24, 2017

Wow, I made git make strange things xD can you reack?

@miri64
Copy link
Member

miri64 commented Oct 24, 2017

No, that's just the harder branch protection config for the release branch ;-)

@kYc0o
Copy link
Contributor Author

kYc0o commented Oct 24, 2017

Indeed, forgot about those specific configurations.

@kYc0o
Copy link
Contributor Author

kYc0o commented Oct 24, 2017

Go!

@kYc0o kYc0o merged commit 4be8887 into RIOT-OS:2017.10-branch Oct 24, 2017
@miri64 miri64 mentioned this pull request Oct 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.
3 participants
@kYc0o @haukepetersen @miri64