-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring recurring transactions #167
Draft
mikev-cw
wants to merge
29
commits into
RIP-Comm:main
Choose a base branch
from
mikev-cw:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikev-cw
added
help wanted
Extra attention is needed
backend
This is backend related
labels
Apr 26, 2024
I can help with the frontend changes. |
@K-w-e Thank you, it would be great! |
…xtstyles fix deprecated textstyles in collaborators page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to address #144. I focused on Backend operations only.
Removed recurring_transaction_amount model, and added recurring_transaction.
Now we've a table that list recurring transactions. When the app is opened, not more than once a day thanks to shared preferences, system will check if a transaction (or more) is needed, and adds them to the transaction table, based on their recurrency type.
Also changed the behavior of "clear db" button on settings: now it re-generates all tables. This is useful when we edit models: there will no more need to delete database from OS.
To check this PR, just chekout, run, press "reset DB" and fill with demo data.
I'm leaving this in draft for now: i need to go deeper on some behaviors, update tests, and remove some dev debug code.
Meanwhile feel free to share your opinions if you want.
Also if anyone wants to help with frontend, which I am not very familiar with, it would help.