Add Story Mode Support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the min and max height so the side bar remains reasonable. Unrelated change couldn't be split out easily: renamed couple of story css rules.
Since most match stats are 0's, we remove them. Maybe they will work at some point but no point in cluttering the state with it. We also add a timestamp and upgrades/currency
The value can be 0, so can't do a simple boolean check
The goal is to have a declarative representation with some keywords to trigger specific behaviors/restrictions.
Also show "completed" challenges differently
We refactored so only the story-challenges component has to worry about it. We show different content when a player wins or loses. We also change the selected city if the previous city has been completed
The popup is also hooked up to show error if not enough teammates are recruited. Clicking ok launches the game too
Update the game mode when half-field is set to be heatseeker. The previous method wasn't fun and this works better.
The champs and CS challenges weren't thought through. So now we have it more fleshed out, using real bots.
If the challenge is completed and human team is winning by 5 then the game is ended and switches to a freeplay screen.
Since both the buttons in the nav bar would want to show a message, we make them disabled and show a message on hover.
tarehart
reviewed
Jun 23, 2020
azeemba
commented
Jun 24, 2020
tarehart
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Story Mode in RLBotGUI.
Since this is a large review, here are some groupings of files to help:
Existing files that changed:
All of these were updated mostly to just add integration points between the existing GUI and Story Mode
rlbot_gui/gui.py
rlbot_gui/gui/css/style.css
rlbot_gui/gui/js/main-vue.js
rlbot_gui/gui/js/main.js
rlbot_gui/gui/main.html
Entrypoints
These are the files that are the main entry points for the Story logic.
rlbot_gui/gui/js/story-mode.js
rlbot_gui/story/story_runner.py
RLBot Specific logic
rlbot_gui/story/story_challenge_setup.py does all the heavy lifting of match creation and state updating
rlbot_gui/story/bots.json
rlbot_gui/story/challenges.json
Critical files
These are the files that have most of the important logic
rlbot_gui/story/story_challenge_setup.py
rlbot_gui/gui/js/story-challenges.js
Screenshots:
Navbar buttons
The button is disabled when it doesn't apply and have a tooltip when disabled.
Story Mode
Fixes #89 and fixes #90