Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventemitter on and once should no more return self #52

Closed
cderv opened this issue Apr 27, 2019 · 0 comments · Fixed by #58
Closed

eventemitter on and once should no more return self #52

cderv opened this issue Apr 27, 2019 · 0 comments · Fixed by #58
Assignees
@RLesur

Comments

@cderv
Copy link
Collaborator

cderv commented Apr 27, 2019

This will be difficult to implement removing a listener and we don't really need that it returns self...
this was interesting for chaining method, but this is something that we can live without.
@RLesur RLesur self-assigned this Apr 27, 2019
@RLesur RLesur mentioned this issue Apr 29, 2019
Closed
RLesur added a commit that referenced this issue Apr 29, 2019
@RLesur
fix #52
c223843
@RLesur RLesur mentioned this issue Apr 30, 2019
Merged
@RLesur RLesur closed this as completed in #58 May 4, 2019
RLesur added a commit that referenced this issue May 4, 2019
@RLesur
Issues 52 57 (#58)
f77b41d 
* fix #52

* rename CDProtocol method get_formals -> get_formals_for_command

* add a get_formals_for_event method in CDProtocol

* add formals to event listeners

* fix #57

* move one comment

* add more tests

* bugfix

* create a wrapper class and an infix %wraps% function

* always use hold when disconnecting client

* re-organize source code

* workaround a weird check error when using lapply or map with a S3 generic

* maybe a waiting time could help to remove the fail on Travis

* bugfix in the print method

* remove warning when running test

* if the stop() function is well removed, hold(witness) should be silent

* modify print method for crrri_callback_wrapper

* remove comment: the tests performs well now

* use a value to create a predicate function

* secure the use of rlang::as_function

* add test about as_predicate usage

* add doc to as_predicate

* add tests for new_callback_wrapper

* add test for get_formals_*

* clearer test and remove old one

* Update tests/testthat/test-cdpsession.R

Co-Authored-By: RLesur <RLesur@users.noreply.github.com>

* Update tests/testthat/test-cdpsession.R

Co-Authored-By: RLesur <RLesur@users.noreply.github.com>

* Update tests/testthat/test-cdpsession.R

Co-Authored-By: RLesur <RLesur@users.noreply.github.com>

* Update R/utils.R

Co-Authored-By: RLesur <RLesur@users.noreply.github.com>

* just check for function see #58 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RLesur RLesur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues 52 57 RLesur/crrri
2 participants
@cderv @RLesur