Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give radios and access groups, take duffelsbags #616

Merged
merged 11 commits into from
Nov 22, 2023

Conversation

Tunguso4ka
Copy link
Contributor

@Tunguso4ka Tunguso4ka commented Nov 21, 2023

About the PR

gives all roles cm headsets
takes from all roles duffelbags
adds colony headset and colonist id card.
adds theirs accessGroups to all roles.

Why / Balance

radios because they need to hear, duh
duffels cause there`s no duffels in cm13

@Tunguso4ka
Copy link
Contributor Author

Ready to review.

Copy link
Contributor

@QuietlyWhisper QuietlyWhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but maybe draft this and I'll get access finished first

@QuietlyWhisper QuietlyWhisper self-assigned this Nov 21, 2023
@QuietlyWhisper QuietlyWhisper marked this pull request as draft November 21, 2023 20:19
@Tunguso4ka Tunguso4ka changed the title Give radios, take duffels to/from all roles Give radios and access groups, take duffelsbags Nov 22, 2023
@Tunguso4ka
Copy link
Contributor Author

yoo, description looks cool. Thanks Whisper.

Tunguso4ka and others added 2 commits November 22, 2023 11:38
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
…er.yml

Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
@Tunguso4ka
Copy link
Contributor Author

Tunguso4ka commented Nov 22, 2023

gonna pray webedit didnt break tabulations.

@Tunguso4ka
Copy link
Contributor Author

"partially fixes assign access to roles #30" will close that issue btw.

@Tunguso4ka Tunguso4ka marked this pull request as ready for review November 22, 2023 13:41
@Tunguso4ka
Copy link
Contributor Author

Ready to review.

@QuietlyWhisper QuietlyWhisper merged commit 9aa6eb9 into RMC-14:master Nov 22, 2023
9 checks passed
@Tunguso4ka Tunguso4ka deleted the give_them_theirs_radios branch November 24, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code Status: Needs Review
Projects
None yet
2 participants