Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change line types and colours #418

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

MonikaFu
Copy link
Collaborator

Closes #389

In this PR I change the colours of benchmark lines to improve their visibility. Resulting chart (on fake data):

image

FYI @Antoine-Lalechere

Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

These functions are not used in too many places, but even if they were, it's nice to see the change would have been equally easy to make. =)

@MonikaFu MonikaFu merged commit 795d41b into develop Oct 13, 2021
@MonikaFu MonikaFu deleted the Improve-benchmark-visibility branch October 13, 2021 16:15
maurolepore pushed a commit that referenced this pull request Oct 13, 2021
maurolepore added a commit that referenced this pull request Oct 13, 2021
This reverts commit 50deb8c.

No idea how this commit ended up in this PR.
maurolepore added a commit that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong color for a second corporate economy
2 participants