Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue on Android < 4.4 #25

Closed
ysamlan opened this issue Mar 11, 2015 · 4 comments
Closed

Security issue on Android < 4.4 #25

ysamlan opened this issue Mar 11, 2015 · 4 comments

Comments

@ysamlan
Copy link

ysamlan commented Mar 11, 2015

See http://android-developers.blogspot.com/2013/08/some-securerandom-thoughts.html

Since this library appears to be directly using numbers from a default-initialized SecureRandom, it should not be used on Android versions below 4.4 without a separate intialization step.

Either the fix should be applied in the code here where applicable (via reflection, probably, to avoid borking non-Android environments), or there should be a big disclaimer and a minimum Android recommendation of 4.4 rather than 2.3.3 for using this library.

@dmjones
Copy link
Contributor

dmjones commented Mar 12, 2015

Thank you for bringing this to my attention. I agree this affects JNCryptor and I'll immediately look into mitigation.

@mr-z-ro
Copy link

mr-z-ro commented Oct 24, 2015

Has any work done on this? I'd love to use this library in LDLN's Android client without a disclaimer on it that devices have to be 4.4+. Perhaps we (at LDLN) could help look into nice ways of implementing this fix if it's not been started yet...

@rnapier
Copy link
Member

rnapier commented Oct 29, 2015

Looking at the linked blog post, there is what seems to be a reasonable mitigation available by seeding the PRNG. Is there a problem with the code in that blog post?

colemarkham added a commit to colemarkham/JNCryptor that referenced this issue Feb 22, 2016
colemarkham added a commit to colemarkham/JNCryptor that referenced this issue Feb 22, 2016
@dmjones dmjones added the wontfix label Apr 5, 2017
@dmjones
Copy link
Contributor

dmjones commented Apr 5, 2017

I've decided not to address Android issues within this project. I don't have the means to test fixes, so this remains a pure Java implementation.

@dmjones dmjones closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants