Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't flush the TX buffer right before transmit #143

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

mcbridejc
Copy link

Addresses Issue #142

This causes random trucated writes, where only 1 or 2 bytes of the packet
are transmitted by the USB serial chip. I'm not exactly sure why; perhaps
there is some kind of buffering that causes the flush command and write
command to make it to the USB device out-of-order.

In any case, I cannot see any reason why a flush should be necessary,
especially on the TX buffer, so it's easy to remove
@LeonJung LeonJung mentioned this pull request Nov 24, 2017
7 tasks
@LeonJung LeonJung changed the base branch from master to develop November 28, 2017 07:19
@LeonJung LeonJung merged commit f1b8238 into ROBOTIS-GIT:develop Nov 28, 2017
@LeonJung LeonJung self-assigned this Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants