Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match develop branch with MLIR develop branch #2798

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Match develop branch with MLIR develop branch #2798

merged 2 commits into from
Feb 22, 2024

Conversation

causten
Copy link
Collaborator

@causten causten commented Feb 20, 2024

No description provided.

@causten causten self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae4331e) 91.55% compared to head (435b598) 91.55%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2798      +/-   ##
===========================================
- Coverage    91.55%   91.55%   -0.01%     
===========================================
  Files          470      470              
  Lines        17699    17701       +2     
===========================================
+ Hits         16205    16206       +1     
- Misses        1494     1495       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
f513f2
Rate old
4b9d64
Diff Compare
torchvision-resnet50 64 2,852.57 2,838.20 0.51%
torchvision-resnet50_fp16 64 6,521.46 6,510.98 0.16%
torchvision-densenet121 32 2,098.02 2,100.32 -0.11%
torchvision-densenet121_fp16 32 3,695.60 3,671.51 0.66%
torchvision-inceptionv3 32 1,601.52 1,603.50 -0.12%
torchvision-inceptionv3_fp16 32 2,578.61 2,579.48 -0.03%
cadene-inceptionv4 16 724.94 724.15 0.11%
cadene-resnext64x4 16 683.10 693.36 -1.48%
slim-mobilenet 64 5,934.66 6,896.30 -13.94% 🔴
slim-nasnetalarge 64 153.76 177.11 -13.19% 🔴
slim-resnet50v2 64 2,667.92 2,666.76 0.04%
bert-mrpc-onnx 8 826.35 825.96 0.05%
bert-mrpc-tf 1 382.96 381.64 0.35%
pytorch-examples-wlang-gru 1 238.99 234.57 1.88%
pytorch-examples-wlang-lstm 1 241.86 241.21 0.27%
torchvision-resnet50_1 1 610.64 610.02 0.10%
cadene-dpn92_1 1 390.75 393.80 -0.77%
cadene-resnext101_1 1 332.18 333.94 -0.53%
onnx-taau-downsample 1 303.77 306.39 -0.86%
dlrm-criteoterabyte 1 21.61 21.58 0.12%
dlrm-criteoterabyte_fp16 1 40.68 40.68 0.01%
agentmodel 1 4,295.53 4,763.40 -9.82% 🔴
unet_fp16 2 56.10 56.18 -0.15%
resnet50v1_fp16 1 886.70 860.99 2.99%
resnet50v1_int8 1 793.91 795.15 -0.16%
bert_base_cased_fp16 64 936.60 936.80 -0.02%
bert_large_uncased_fp16 32 292.65 292.72 -0.02%
bert_large_fp16 1 184.49 184.71 -0.12%
distilgpt2_fp16 16 1,641.01 1,636.09 0.30%
yolov5s 1 493.86 497.42 -0.72%
tinyllama 1 32.62 32.61 0.04%
vicuna-fastchat 1 157.51 155.44 1.33%
whisper-tiny-encoder 1 334.97 336.11 -0.34%
whisper-tiny-decoder 1 374.21 373.22 0.26%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten
Copy link
Collaborator Author

causten commented Feb 22, 2024

I opened ROCm/rocMLIR#1429 to track the two models that have worse performance

@causten causten merged commit 5c2e9c4 into develop Feb 22, 2024
50 of 52 checks passed
@causten causten deleted the bump_mlir_62 branch February 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants