Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let hipcc link -lpthread -lm by default #637

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Let hipcc link -lpthread -lm by default #637

merged 1 commit into from
Sep 14, 2018

Conversation

yxsamliu
Copy link
Contributor

rocRAND assumes hipcc linking with -lpthread -lm by default.

@aaronenyeshi
Copy link
Contributor

Thanks Sam, does this fix this PR ROCm/rocRAND#29

@yxsamliu
Copy link
Contributor Author

yes

@mangupta mangupta merged commit d6ce39c into master Sep 14, 2018
@mangupta mangupta deleted the add-pthread branch September 14, 2018 07:51
@ax3l
Copy link

ax3l commented Sep 3, 2021

This patch is very unstable and does not work with modern CMake, which directly uses clang -x hip.
rocRAND (and all other ROC/HIP packages) should publicly declare their dependencies instead of hoping that the hipcc wrapper is used to fix missing declarations of dependencies.

X-ref: ROCm/rocRAND#29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants