Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 2 #689

Merged
merged 1 commit into from
Nov 10, 2022
Merged

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 2 #689

merged 1 commit into from
Nov 10, 2022

Conversation

emankov
Copy link
Collaborator

@emankov emankov commented Nov 10, 2022

  • Continued supporting hipification to MIOpen based on miopen.h
  • Updated the synthetic test cudnn2miopen.cu accordingly
  • MIOpen has its own types, equal to HIP ones but without any connection (like redefines, for instance):
    • Example: cudaStream_t / hipStream_t / miopenAcceleratorQueue_t
    • [Solution] Started to use the "roc" mapping for Runtime APIs as well, which is used only under the --roc option

[ToDo]

  • Form the above solution as a standalone function instead of an ad-hock workaround
  • Add the needed changes in the hipify-perl script generation
  • Start to generate yet another CUDA2HIP Markdown doc regarding cuDNN support in MIOpen
  • Decide what to do with the still being generated but not being published CUDNN_API_supported_by_HIP.md for cuDNN support in the obsolete hipDNN

@emankov
[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 2
5c63ac4 
+ Continued supporting hipification to MIOpen based on `miopen.h`
+ Updated the synthetic test `cudnn2miopen.cu` accordingly
+ MIOpen has its own types, equal to HIP ones but without any connection (like redefines, for instance):
  + Example: cudaStream_t / hipStream_t / miopenAcceleratorQueue_t
  + [Solution] Started to use the "roc" mapping for Runtime APIs as well, which is used only under the `--roc` option

[ToDo]
+ Form the above solution as a standalone function instead of an ad-hock workaround
+ Add the needed changes in the `hipify-perl` script generation
+ Start to generate yet another CUDA2HIP Markdown doc regarding cuDNN support in MIOpen
+ Decide what to do with the still being generated but not being published `CUDNN_API_supported_by_HIP.md` for cuDNN support in the obsolete hipDNN
@emankov emankov added feature Feature request or implementation DNN DNN-related MIOpen labels Nov 10, 2022
@emankov emankov self-assigned this Nov 10, 2022
@emankov emankov merged commit 2fd116b into ROCm:amd-staging Nov 10, 2022
@emankov emankov added the sync Syncing update label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@searlmc1 searlmc1 Awaiting requested review from searlmc1 searlmc1 is a code owner

@dennyiriawan dennyiriawan Awaiting requested review from dennyiriawan

Assignees

@emankov emankov

Labels
DNN DNN-related feature Feature request or implementation MIOpen sync Syncing update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emankov