Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add dual mac insttruction for gfx11." #1683

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Revert "Add dual mac insttruction for gfx11." #1683

merged 1 commit into from
Mar 1, 2023

Conversation

cmingch
Copy link
Contributor

@cmingch cmingch commented Mar 1, 2023 

This reverts commit 78a8c51496a7ac5b58d6976009e08bd42a14258f.

@cmingch cmingch requested review from pruthvistony, TonyYHsieh and imcarsonliao and removed request for pruthvistony March 1, 2023 05:35
@nakajee
Copy link
Contributor

nakajee commented Mar 1, 2023

The previous commit is not fully reverted.
e98916f#diff-fb6a686182f16eb54af3c628f38593f347f68aba31de903983023c560288d7a1

  • popAllInstructions related code should be deleted
  • 4 test cases in wave32 folder are not removed
  • also, need to remove wave32 from pytest.ini

@cmingch
Copy link
Contributor Author

cmingch commented Mar 1, 2023

The previous commit is not fully reverted. e98916f#diff-fb6a686182f16eb54af3c628f38593f347f68aba31de903983023c560288d7a1

  • popAllInstructions related code should be deleted
  • 4 test cases in wave32 folder are not removed
  • also, need to remove wave32 from pytest.ini

done

@nakajee
Copy link
Contributor

nakajee commented Mar 1, 2023

done

Thanks for your update. Please make sure all CI tests pass.

@eidenyoshida
Copy link
Collaborator

Looks like it passed the 5.5 precheckin but failed the 5.4 extended

@yoichiyoshida yoichiyoshida merged commit 8daf7b7 into ROCm:develop Mar 1, 2023
AlexBrownAMD pushed a commit to AlexBrownAMD/Tensile that referenced this pull request Mar 8, 2023
@cmingch @AlexBrownAMD
Revert "Add dual mac insttruction for gfx11." (ROCm#1683)
051844d 
This reverts commit 78a8c51.
@sdli1995 sdli1995 mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoichiyoshida yoichiyoshida yoichiyoshida approved these changes

@imcarsonliao imcarsonliao imcarsonliao approved these changes

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh

@eidenyoshida eidenyoshida Awaiting requested review from eidenyoshida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmingch @nakajee @eidenyoshida @imcarsonliao @yoichiyoshida