Call npvt routines from hipBLAS #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
approved these changes
Aug 26, 2021
IIRC, the concern was that allowing nullptr to be passed as in cuBLAS was bad coding practice and could result in a user accidentally passing a nullptr and getting degraded numerical stability without warning. The first solution was to have a bool argument that defaulted to requiring a non-null ipiv array, but this broke C compatibility because C can't do default arguments. That's when we switched to separate functions, which I think is preferred by both the team and the feature requester. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses SWDEV-297252.
This PR allows the getrf and getri routines in hipBLAS to receive null ipiv arrays, disabling pivoting in these routines similarly to cuBLAS.