Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake modules rather than find package to deduce HIP configs #54

Closed
wants to merge 1 commit into from

Conversation

NEELMCW
Copy link

@NEELMCW NEELMCW commented Mar 6, 2018

resolves #___

Summary of proposed changes:

  • Avoid need for hipConfig.cmake that would get generated currently only as part of ROCM installation
  • Instead makes use of FindHIP.cmake module that gets shipped with HIP to set and deduce hip build and link configs
  • TODO: The install script still looks for hip_hcc and rocBLAS on NV stack. This needs to be conditionallychecked based on target platform

@amcamd
Copy link
Contributor

amcamd commented Mar 6, 2018

Please create your own branch. There is no agreement that this should be submitted to the develop branch.

@amcamd amcamd closed this Mar 6, 2018
@NEELMCW
Copy link
Author

NEELMCW commented Mar 7, 2018

@amdcamd OK Will do the needful ... Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants