Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interfaces to CUB 1.16 #192

Merged
merged 65 commits into from
Apr 12, 2022
Merged

Update interfaces to CUB 1.16 #192

merged 65 commits into from
Apr 12, 2022

Conversation

mfep
Copy link
Contributor

@mfep mfep commented Mar 16, 2022 •
edited
Loading

  • Testing whether special floating point values (e.g. NaNs) are properly sorted
  • WarpExchange uses the rocPRIM primitive now
  • Public interfaces are updated to comply with CUB 1.16
    • Referencing CUB and thrust version 1.16 by the CUB backend
    • Deprecated type traits. The use of standard header <type_traits> is suggested instead.
    • Added UniqueByKey to DeviceSelect
    • DeviceRadixSort now supports problem sizes over INT_MAX
    • Added new interfaces to BlockAdjacentDifference and deprecated the old ones
    • Added DeviceAdjacentDifference
    • Added missing structs to thread_operators.hpp in the rocPRIM backend
    • Additional tiny changes to the public interface

Depends on ROCm/rocPRIM#316

Vince and others added 30 commits February 16, 2022 19:25
@neon60
test_hipcub_device_radix_sort.cpp Correctly test -NaN.
285ac84
@neon60
test_utils::native_half -NaN to float fix
181623e
@neon60
Merge branch '85-sorting-tests-for-floating-points-don-t-test-nan' in…
d4aed5e 
…to 'develop_stream'

Resolve "Sorting tests for floating-points don't test -NaN"

Closes #85

See merge request amd/hipCUB!71
@neon60
hipcub::WarpExchange interface to ::rocprim::warp_exchange
3d0ed35
@neon60
Fix after review
54e4ce9
@mfep @neon60
Merge branch '88-use-rocprim-s-warp-exchange' into 'develop_stream'
c92bc4b 
Resolve "Use rocPRIM's warp exchange"

Closes #88

See merge request amd/hipCUB!73
@mfep
Default CUDA architecture is 53 to fix __half
532d570
@mfep
Apply 1 suggestion(s) to 1 file(s)
27a3050
@mfep
Merge branch '99-fix-nvidia-ci' into 'develop_stream'
37b77ee 
Default CUDA architecture is 53 to fix __half

Closes #99

See merge request amd/hipCUB!77
@mfep
Added NVGPU_TARGETS to gitlab-ci
a7eca0a
@mfep
Update .gitlab-ci.yml file
f20c64f
Merge branch 'nvcc-gpu-targets' into 'develop_stream'
13d482f 
Nvcc gpu targets

See merge request amd/hipCUB!80
Changes from [PR346](NVIDIA/cub#346)
4547d27
Add deprecation warnings.
918f762
Update of deprecated statement.
e0040e2
Adding constants from [PR418](NVIDIA/cub#418).
971038e
Fix deprecation warnings.
72accdf
Fix a forgotten deprecation warnings.
f3d2ec2
Fix deprecation warnings.
edd7480
Fix deprecation warnings for nvcc.
28afd4c
Replace '__host__ __device__' by 'HIPCUB_HOST_DEVICE'
9cbd0bc
Added Cuda standard
311c282
Merge branch '95-port-minor-api-changes-from-cub-1-16' into 'cub-1.16'
153da9f 
Resolve "Port minor API changes from CUB 1.16"

See merge request amd/hipCUB!76
@mfep
Bumped referenced CUB and thrust version to 1.16
67a2ad8
@mfep
Download thrust in test/extra
00679bd
@mfep
Merge branch 'bump-cub-version' into 'cub-1.16'
7cefe6d 
Referencing CUB/thrust 1.16

See merge request amd/hipCUB!81
@mfep
Added the interface for UniqueByKey
87f375c
@mfep
Added test for UniqueByKey
1fa6fa5
@mfep
Added benchmark for UniqueByKey
1ee6b93
@mfep
Add UniqueByKey interface
d9a419d
Théo Battrel and others added 21 commits March 16, 2022 10:13
Add deprecation warnings for Flags API
f4e0568
Ignore deprecation warnings for Flags API tests
e579977
Fix Subtract interfaces
f696dee
Fix SubtractRightPartial not using the right method
e6b0080
Add benchmark for AdjacentDifference (Subtract)
95938ba
Add test for AdjacentDifference (Subtract)
e48443b
Use 'HIPCUB_HOST_DEVICE' macro
5f1a8bf
Fix a typo
4d4a89e
Fix interfaces of Subtract not matching the CUB one
a25f449
Upadte the tests and benchmarks to the fixed interfaces of Subtract
0a57625
Fix to use temp_storage_ in subtract call
9d5e2ae
Fix the tests of Subtract to work with the CUB interfaces
fffd43d
Add the macros to ignore warning in config.hpp and remove it from blo…
fefd28a 
…ck_adjacent_difference file and the from the tests
@mfep
Device adjacent difference CUB backend
acea1a7
@mfep
New thread operators [skip ci]
cab5660
@mfep
Test device adjacent difference [skip ci]
498395a
@mfep
Device adjacent difference rocPRIM backend
2819bf3
@mfep
Added new headers to the hipcub.hpp-s
8304147
@mfep
Benchmark for device adjacent difference
18fbfd7
Merge branch '94-port-block-device-adjacentdifference' into 'cub-1.16'
41d51de 
Resolve "Port {Block|Device}AdjacentDifference"

See merge request amd/hipCUB!83
Merge branch '94-device-adjacent-difference' into 'cub-1.16'
995ac84 
Porting DeviceAdjacentDifference

See merge request amd/hipCUB!84
@mfep mfep marked this pull request as ready for review March 22, 2022 08:33
@stanleytsang-amd stanleytsang-amd merged commit 488b6c8 into develop Apr 12, 2022
@mfep mfep deleted the cub-1.16 branch April 12, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfep @stanleytsang-amd @sbalint98