Rollback Grafana for Compatibility with deprecated plugin #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular plugin (#416) Signed-off-by: coleramos425 <colramos@amd.com>
coleramos425
requested review from
dgaliffiAMD and
benrichard-amd
and removed request for
dgaliffiAMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filing PR in response to #416
This PR is a short-term solution to meet immediate requirements from El Capitan to get started with Grafana. I rolled back the Grafana version that's downloaded in the Dockerfile so that the Angular-based Omniperf plugin can still be used.
We still need to implement a long-term solution, which could be migrating our existing deprecated Angular plugin to React. More info on how to do that is given in Grafana release notes:
https://grafana.com/blog/2024/03/11/removal-of-angularjs-support-in-grafana-what-you-need-to-know/
Waiting to discuss roadmap with @nartmada and team to determine a preferred long-term fix.