Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Causal GUI: Linting, synced y-range, remove unused imports/variables, and bug fixes #274

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Causal GUI: Linting, synced y-range, remove unused imports/variables, and bug fixes #274

merged 9 commits into from
Apr 4, 2023

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Apr 3, 2023

Bug Fixes

  • Error bars for causal data
    • the +/- values were treated as percents of original value when in reality they were values
  • Mislabeled function_regex and exp_regex
    • in the code, progress points were misinterpreted as "experiments" when, in fact, the function/line stuff was the experiments
  • Unused dataframe creation in add_latency
  • Latency points not showing up in plots from JSON data
    • looking for "arrivals" key instead of "arrival"
    • latency_point class had duplicate __init__ functions
  • --stddev argument unused
    • not effectively assigned to num_stddev in parser.py

Miscellaneous

  • Workflow which runs flake8 on source/python/gui files
  • Removed numerous unused by assigned variables (flake8 linting error)
  • Removed numerous unused imports (flake8 linting error)
  • Replaced if X == False with if not X (flake8 linting error)
  • The y-range of all plots is identical for all plots now
    • this vastly improves initial comparison of impact between plots

@jrmadsen
GUI: python linting workflow
0774bc8 
- runs flake8 on code in source/python/gui
@jrmadsen
GUI: flake8 settings in source/python/gui/setup.cfg
66b2ca8 
- ignore E501 errors (line too long)
- ignore W503 errors (line break before binary operator)
@jrmadsen
GUI: setup.py updates
ce90ea6 
- remove unused imports
@jrmadsen
GUI: __main__.py updates
095e07d 
- stddev is float value
- remove unused imports
- effectively propagate the --stddev argument
@jrmadsen
GUI: gui.py updates
180f006 
- remove unused imports
- fix light mode
- sync initial y range of all causal plots
- fix error bars for causal data
- set x-ticks to 5
- set y-ticks to 10
- only display top 99% of samples
- separate global declarations and assignments to global values
- remove unused variable assignments
- fix mislabeled function_regex and exp_regex
- change if X == False to if not X
@jrmadsen
GUI: header.py updates
7268ff2 
- remove unused imports
- fix mislabeled function_regex and exp_regex
@jrmadsen
GUI: parser.py updates
24eb933 
- add set_num_stddev function for manipulating global num_stddev value
- remove unused variables
- fix latency point object (duplicated __init__ function)
- fix handling latency in JSON
- fix formatting of validation format error message
- replace if X == False with if not X
- fix unused dataframe creation in add_latency
- fix flake8 do not assign lambda for name_wo_ext (use def)
@jrmadsen
GUI: gui.py updates
5ba704f 
- replace misnamed "func_list" with "experiment_list"
- replace misnamed "exp_list" with "progpt_list"
@jrmadsen jrmadsen added bug fix Fixes a bug causal profiling Updates to causal profiling capability causal-profiling-gui GUI for causal profiling labels Apr 3, 2023
@jrmadsen
GUI: fix python workflow
4af91a1 
- quote python versions to avoid truncating 3.10 to 3.1
@jrmadsen jrmadsen merged commit cdddb0d into ROCm:develop Apr 4, 2023
@jrmadsen jrmadsen deleted the causal-gui-updates branch April 4, 2023 00:01
jrmadsen added a commit that referenced this pull request Apr 12, 2023
@jrmadsen @JoseSantosAMD
Casual Profiling GUI (#265)
cc14b52 
* Long workload name layout fix (#269)

* changed layout to fit experiment names

- added span to show full name
- shortened name to fit dropwdown
- changed layout for added consistency

* layout Fixes

- refresh button is to the right
- header is more consistent across different width screens

* header layout update

- center div makes turns into multiple lines if not all items fit

* slight improvement for header/graph spacing

* Fixed refresh button shape and function

- moved find_causal_files to parser so that main and gui can access
- resized refresh width to allow for same shape across different screens

* all graphs now have the same width

- graphs now have same width

- chart headers start well below the header with filters

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

* Causal GUI: Linting, synced y-range, remove unused imports/variables, and bug fixes (#274)

* GUI: python linting workflow

- runs flake8 on code in source/python/gui

* GUI: flake8 settings in source/python/gui/setup.cfg

- ignore E501 errors (line too long)
- ignore W503 errors (line break before binary operator)

* GUI: setup.py updates

- remove unused imports

* GUI: __main__.py updates

- stddev is float value
- remove unused imports
- effectively propagate the --stddev argument

* GUI: gui.py updates

- remove unused imports
- fix light mode
- sync initial y range of all causal plots
- fix error bars for causal data
- set x-ticks to 5
- set y-ticks to 10
- only display top 99% of samples
- separate global declarations and assignments to global values
- remove unused variable assignments
- fix mislabeled function_regex and exp_regex
- change if X == False to if not X

* GUI: header.py updates

- remove unused imports
- fix mislabeled function_regex and exp_regex

* GUI: parser.py updates

- add set_num_stddev function for manipulating global num_stddev value
- remove unused variables
- fix latency point object (duplicated __init__ function)
- fix handling latency in JSON
- fix formatting of validation format error message
- replace if X == False with if not X
- fix unused dataframe creation in add_latency
- fix flake8 do not assign lambda for name_wo_ext (use def)

* GUI: gui.py updates

- replace misnamed "func_list" with "experiment_list"
- replace misnamed "exp_list" with "progpt_list"

* GUI: fix python workflow

- quote python versions to avoid truncating 3.10 to 3.1

---------

Co-authored-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug causal profiling Updates to causal profiling capability causal-profiling-gui GUI for causal profiling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen