Perfetto annotation from timemory components #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support perfetto annotations via timemory component data, e.g. use PAPI component for exact HW counter annotations
- remove --default-components argument as this overrides any components set in configuration file - required by perfetto annotation via timemory data tests
jrmadsen
added
bug fix
- filter out unavailable timemory components before attempting to invoke the annotate operation on the bundle
- account for no PAPI support
- replace '-d wall_clock peak_rss' with '--env OMNITRACE_TIMEMORY_COMPONENTS="wall_clock peak_rss"'
- fix misnamed test
- restrict binary rewrite to run function to force instrumentation despite heuristics
- print {available,overlapping,excluded,instrumented} functions during binary rewrite
- add allow-overlapping flag
- do not disable PAPI if perf_event_paranoid > 2 but has CAP_SYS_ADMIN capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--default-componentsargument toomnitrace-instrument(causes unexpected behavior)