Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weight padding for moe #119

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Add weight padding for moe #119

merged 7 commits into from
Aug 2, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Aug 2, 2024

Add weight padding for fused_moe kernel.
The padding is enabled by default, use VLLM_MOE_PADDING=0 to disable it.

shajrawi
shajrawi previously approved these changes Aug 2, 2024
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@charlifu charlifu requested a review from shajrawi August 2, 2024 22:12
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlifu charlifu merged commit 5fac73f into main Aug 2, 2024
13 checks passed
@charlifu charlifu deleted the charlifu/moe_padding branch August 5, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants