GL/Vulkan: Skate 2

[MarioSonic2987]

@kd-11 @raven02
Reaches to ingame in Vulkan. OpenGL is too slow.

DX12:

F {rsx::thread} class std::runtime_error thrown: Unsupported DXGI format 0x57
(in file C:\rpcs3\rpcs3\Emu\RSX\D3D12\D3D12Formats.cpp:201)

GL:

Vulkan:

Shaderlog DX12
Shaderlog GL
Shaderlog Vulkan
RenderDoc Vulkan (Character Creation)

[dbz400]

Did #2384 help for dx12 render?

[MarioSonic2987]

Still happens. https://gist.github.com/MarioSonic2987/d787f6fe972df0ddab7a7435e77eea57

[Zangetsu38]

@raven02 you have a set no correct value.
I have Fixed #2385

[dbz400]

thx i must be asleep .

[MarioSonic2987]

With #2385, gives Win32 error. https://gist.github.com/MarioSonic2987/b03461756e121e356c66a84823bc8085#file-log-dx12-skate-2-2-log

[Zangetsu38]

Yes, exactly same crash with other several game, DX12 need just more work, but nothing to do with it, the problem is elsewhere.

[MarioSonic2987]

Remains labels for this issue.

[mchtt]

Awesome progress ! Finally one of the skate game goes ingame, this made my day, you guys are amazing !

[MarioSonic2987]

With #2482, it's improved a bit.

[MarioSonic2987]

With RenderDoc, it seems correctly rendered (with remove some layers).
RenderDoc Vulkan

[MarioSonic2987]

In 2b79a36, it's improved a bit (The text below the logo is readable).

[MarioSonic2987]

Video

[MarioSonic2987]

With SPU precise, map doesn't disappear.

[mchtt]

are you able to move on ground without falling ?

[MarioSonic2987]

I haven't tested further, but I think yes.

[MarioSonic2987]

I tested now, and I'm not able to move.

[mchtt]

same here, the demo timer is going on but no response from inputs !
at least the character is not falling through the ground anymore :-D

[mchtt]

with today latest build i went at the same point with the full game (not demo), i can open the menu but the character does not respond to inputs ! weird, at least it's now ingame

[mchtt]

also do you know that skate games register joysticks inputs @ 120 hz ? will it be a problem ?

[MarioSonic2987]

@mchtt Can you test this game with Vulkan if your graphics card supports it? My GeForce 820M doesn't support it.

[mchtt]

sorry for the late reply,
just tried it (demo version) 👍 24/06/2017 build.
a lot of improvements regarding framerate !
30 fps in every menus, new random freezes while loading, 40-60 fps in-game, falling to the ground again.
while falling the skater responds to my gamepad inputs :-D
still that ORANGE graphics (vulkan/open GL)

[mchtt]

for today (build 5154) i was able to play the full game and the demo like in this video
default options

[MarioSonic2987]

Tested in c85806c:

There's zfighting in pillars.

[MarioSonic2987]

Tested in f24491d:

Log OpenGL
Shaderlog OpenGL
RenderDoc OpenGL

[mchtt]

looks way better :-)

[MarioSonic2987]

@mchtt In emulator, still happens (orange issue).

[MarioSonic2987]

With #4265, has the same improvements as Skate 3. Objects are no longer flickering and shadows are rendered, but not perfectly. Orange filter is still there,

[MarioSonic2987]

With #4311, orange filter is improved:

[MarioSonic2987]

With #4312, there's no orange filter, but a multicolor filter. Actually, it fixes gamma, like Skate 3.

RenderDoc:

[MarioSonic2987]

With a17025c:

Log OpenGL
Shaderlog OpenGL
RenderDoc OpenGL

[kd-11]

Like every other game with grading filter issues, this game is using a 3d palette for color grading. Either the contents of the 3d lookup palette are wrong or the computed vector is inacurrate. I'm leaning more towards the latter. Hard to tell without further digging.

[kd-11]

The palette is definately wrong, no doubt about it. It does not have the usual left-right, top-bottom gradient expected which makes me think 3d texture uploads are still broken. Will take a proper look probably in the next few days.

[Asinin3]

Fixed with #4382

[AniLeo]

Closing as solved

[MarioSonic2987]

Only remains broken shadows (same glitch as Skate 3).

[sheddup]

Whats the performance like compared to Skate 3?

[Asinin3]

@sheddup Github isn't the place for discussion, you can ask on discord: https://discord.me/RPCS3 or our forums.