Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Tracker for Broken Spawn #7522

Closed
5 tasks done
jeremybris opened this issue Feb 18, 2020 · 24 comments
Closed
5 tasks done

Meta Tracker for Broken Spawn #7522

jeremybris opened this issue Feb 18, 2020 · 24 comments

Comments

@jeremybris
Copy link

jeremybris commented Feb 18, 2020

Quick summary

FIXED as of #7565. Thank you elad335!

  • The player spawns out of bounds.
  • The player falls through the floor.

Details

Unrelated bug

  • Sly 2 [BCES00968] black screen
@jeremybris
Copy link
Author

Interestingly, this was just fixed for me in Ratchet & Clank: Tools of Destruction [BCES00052] in #7304 !!! Can anyone confirm or deny the others were fixed? I will do more testing.

@jeremybris
Copy link
Author

I think this fixed

  • Ratchet & Clank: Tools of Destruction [BCES00052]
  • Skate 2 [BLES00461]

Not fixed. It is an unrelated bug.

  • Sly 2 [BCES00968]

The others I can not comment on. I have not experienced them.

@Cervoxx
Copy link

Cervoxx commented Feb 18, 2020

  • Ratchet & Clank: Tools of Destruction [BCUS98127]

Not fixed, but significantly reduced. Tested this by closing and reopening the game multiple times, and it happened only once.

Logs: https://files.catbox.moe/5s0455.gz

@lainiwaku
Copy link

lainiwaku commented Feb 19, 2020

Interestingly, this was just fixed for me in Ratchet & Clank: Tools of Destruction [BCES00052] in #7304 !!! Can anyone confirm or deny the others were fixed? I will do more testing.

on resistance fall of man it's a regression
On ASMJIT recompiler =
before #7304 = player REspawn and jump out of the map
after #7304 = black screen
On LLVM recompiler =
Enemies spawns bugged and make the emulator crash

Should a dedicated threads should be opened for that regression ?
EDIT: Nevemind i will directly adress the issue on #7492
EDIT 2 : i just tested with "SPU DECODER : Interpreter (fast)"
and it works just great with this one, player can respawn, enemy spawn without bugs

@lainiwaku
Copy link

lainiwaku commented Feb 19, 2020

RPCS3ASMJIT.log.gz
LLVM log :
RPCS3.log

@digitaldude555
Copy link

Either #7492 #7130 #5806 needs closing or this issue needs closing. @AniLeo what you think.

@jeremybris
Copy link
Author

jeremybris commented Feb 19, 2020

  • Ratchet & Clank: Tools of Destruction [BCUS98127]

Not fixed, but significantly reduced. Tested this by closing and reopening the game multiple times, and it happened only once.

Logs: https://files.catbox.moe/5s0455.gz

@Cervoxx I'm glad you tested it. Lainiwaku says he found a workaround by doing "SPU DECODER : Interpreter (fast)". Will you try that, and tell me if it fixes the bug, please?

@Cervoxx
Copy link

Cervoxx commented Feb 19, 2020

@Cervoxx I'm glad you tested it. Lainiwaku says he found a workaround by doing "SPU DECODER : Interpreter (fast)". Will you try that, and tell me if it fixes the bug, please?

Will do soon. Not sure if its necessary or not, but bear in mind that my Region ID is different to the one you have listed. As far as I understand I've got the american version whilst you've got the european version, assuming I'm reading this correctly.

image

@elad335
Copy link
Contributor

elad335 commented Feb 19, 2020

Test regressions with #7532

@jeremybris

This comment has been minimized.

@Cervoxx
Copy link

Cervoxx commented Feb 20, 2020

Test regressions with #7532

@elad335
You will need to make this build if you want me to test it. A windows build wont work for me since I use linux so I need an appimage, and your documentation on manually building rpsc3 for linux is outdated. And as a user unfamiliar with git, I gave up even after setting up a ubuntu 18.04 VM in an attempt to build that branch where the pull request originated from. A bit too much frustration here.

@jeremybris

@Cervoxx I'm glad you tested it. Lainiwaku says he found a workaround by doing "SPU DECODER : Interpreter (fast)". Will you try that, and tell me if it fixes the bug, please?

Still on my radar to do this, pardon my delay.

@Yahfz
Copy link
Contributor

Yahfz commented Feb 20, 2020

Add Grand Theft Auto IV NPEB00882

@jeremybris
Copy link
Author

jeremybris commented Feb 20, 2020

Still on my radar to do this, pardon my delay.

No need to try that anymore, thanks anyways. Another person confirmed the new build works for Ratchet and Clank. It should work for you too when publicly posted.

Add Grand Theft Auto IV NPEB00882

@Yahfz I added it. Please post your results, if https://ci.appveyor.com/api/buildjobs/pe9poxs8twn8nig3/artifacts/rpcs3-v0.0.8-6fb3307a_win64.7z (elad's fix), fixes it, so I can close this thread.

@dio-gh
Copy link
Contributor

dio-gh commented Feb 20, 2020

Is it not that GTA IV just requires accurate xfloat? @Yahfz

@jeremybris
Copy link
Author

jeremybris commented Feb 20, 2020

I will be closing this soon. In conlusion, thanks to elad's work,

Unrelated Bugs

@digitaldude555
Copy link

@jeremybris uncheck all of them except skate they are not fixed and pr was closed.

@web1018
Copy link

web1018 commented Feb 20, 2020

Yes. I can confirm that it's still not fixed. Elad closed the PR and the one that he has merged instead does not fix the regression. Resistance: Fall of Man is back to having black screen after the player dies and the issue is still standing.

@jeremybris
Copy link
Author

jeremybris commented Feb 20, 2020

Yes. I can confirm that it's still not fixed. Elad closed the PR and the one that he has merged instead does not fix the regression. Resistance: Fall of Man is back to having black screen after the player dies and the issue is still standing.

Ohh understood, thanks for correcting me. I thought elad closed that PR because elad included the fix in his next PR. I'll leave this open, until it is fixed in the master.

@web1018
Copy link

web1018 commented Feb 20, 2020

Yes. I can confirm that it's still not fixed. Elad closed the PR and the one that he has merged instead does not fix the regression. Resistance: Fall of Man is back to having black screen after the player dies and the issue is still standing.

Ohh understood, thanks for correcting me. I thought elad closed that PR because elad included the fix in his next PR. I'll leave this open, until it is fixed in the master.

I thought so myself after reading his comments. But when I tested it, I saw that it was not fixed. So we will have to keep this open until we know for sure that these issues are fixed.

@lainiwaku
Copy link

lainiwaku commented Feb 20, 2020

maybe @elad335 was thinking his PR #7542 would fix it so he closed #7532 ?

@digitaldude555
Copy link

Gonna need an update on whats fixed now that #7565 merged.

@digitaldude555
Copy link

@jeremybris resistance is fixed you can close this issue now.

@AniLeo
Copy link
Member

AniLeo commented Feb 29, 2020

Closing as mentioned issues should now be fixed

@AniLeo AniLeo closed this as completed Feb 29, 2020
@jeremybris
Copy link
Author

jeremybris commented Feb 29, 2020

Gonna need an update on whats fixed now that #7565 merged.

The reports are mixed. It seems like the "spawning out of bounds" bug has been replaced by "the emulator crashes when you die", which may have been fixed #7562 (comment) or it happens randomly #7565 (comment).

In my opinion, this issue should be closed, and a new issue should be opened. It may be an unrelated bug or nonexistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants