-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/windows: use Qt's high dpi scaling #4908
Conversation
Removed the backend hack. I changed the code so that APPLE uses AA_EnableHighDpiScaling and therefore devicePixelRatio as well. The rounding error (width/height mismatch) still persists. |
ac9b912
to
eb30e80
Compare
The latest version seems to fix an issue I've been having for a month where fullscreen is always downsampled to 720p, even though I have windows set to 1080p and resolution scaling at 4k. I'm not 100% confident on this though as the issue seems to come and go with different builds. Edit: I'm not using dpi scaling or anything like that though, so it might be unrelated. Also I'm using the dll's from 5.11.2, which might explain why I have issues. |
Disregard my previous post I guess, I compiled my own version and it's not working but the one I downloaded from appveyor is. |
you are probably on a different Qt version or used different dlls |
P5: E {RSX [0x0000000]} RSX: Swapchain: Swapchain creation failed because dimensions cannot fit. Max = 1280, 710, Requested = 1280, 711 |
@vietnam13231 normal, no idea who have said that, but this issue is random, and absolutely don't depending this commit, no relate, this commit only said, "Read dpi value on this system" that all |
This should work as before now, even on window's high dpi settings.
The main reason for this PR was to use Qt's frontend highdpi stuff instead of using SetProcessDPIAware.
Also fixes a crash on Vulkan when resizing the window to a small height (by setting a min height on Qt side XD).
There is a bug still present in the gs-frame that causes a swapchain error. The max is 1 less than the calculated size on eg. pixelratios of 2E {rsx::thread} RSX: Swapchain: Swapchain creation failed because dimensions cannot fit. Max = 993, 604, Requested = 994, 604